Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor][Plugins] Move common attributes to Core/Base #522

Closed
markwolff opened this issue Nov 12, 2019 · 0 comments · Fixed by #1160
Closed

[Refactor][Plugins] Move common attributes to Core/Base #522

markwolff opened this issue Nov 12, 2019 · 0 comments · Fixed by #1160
Labels
enhancement New feature or request

Comments

@markwolff
Copy link
Member

markwolff commented Nov 12, 2019 •
edited
Loading

From #503 (comment)
Attributes which are used in all/most plugins should be shared via some enum in core or base
@mayurkale22 mayurkale22 added enhancement New feature or request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Nov 12, 2019
@rubenvp8510 rubenvp8510 mentioned this issue Jan 22, 2020
Closed
@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jan 24, 2020
@markwolff markwolff mentioned this issue Jun 9, 2020
Merged
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@Flarna
chore: move api into peer dependency (open-telemetry#522)
2a30f62 
* chore: move api into peer dependency

* fix peer-api-check script
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this issue Mar 13, 2024
@Flarna
chore: move api into peer dependency (open-telemetry#522)
6265dcc 
* chore: move api into peer dependency

* fix peer-api-check script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@markwolff @mayurkale22