fix!: span name on instrumentation-xml-http-request (#3672)

* fix: remove HTTP in span name * fix: add entry in CHANGELOG.md * fix: add breaking change changelog * Update experimental/packages/opentelemetry-instrumentation-xml-http-request/src/xhr.ts Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de> * Remove duplicate changelog entry --------- Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de> Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
open-telemetry · Mar 17, 2023 · 52facfa · 52facfa
1 parent 89a984a
commit 52facfa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md
@@ -6,6 +6,8 @@ All notable changes to experimental packages in this project will be documented
 
 ### :boom: Breaking Change
 
+* fix: remove HTTP/HTTPS prefix from span name in instrumentation-xml-http-request [#3672](https://github.com/open-telemetry/opentelemetry-js/pull/3672) @jufab
+
 ### :rocket: (Enhancement)
 
 ### :bug: (Bug Fix)

diff --git a/experimental/packages/opentelemetry-instrumentation-xml-http-request/src/xhr.ts b/experimental/packages/opentelemetry-instrumentation-xml-http-request/src/xhr.ts
@@ -329,7 +329,7 @@ export class XMLHttpRequestInstrumentation extends InstrumentationBase<XMLHttpRe
       this._diag.debug('ignoring span as url matches ignored url');
       return;
     }
-    const spanName = `HTTP ${method.toUpperCase()}`;
+    const spanName = method.toUpperCase();
 
     const currentSpan = this.tracer.startSpan(spanName, {
       kind: api.SpanKind.CLIENT,

diff --git a/experimental/packages/opentelemetry-instrumentation-xml-http-request/test/xhr.test.ts b/experimental/packages/opentelemetry-instrumentation-xml-http-request/test/xhr.test.ts
@@ -318,7 +318,7 @@ describe('xhr', () => {
 
         it('span should have correct name', () => {
           const span: tracing.ReadableSpan = exportSpy.args[1][0][0];
-          assert.strictEqual(span.name, 'HTTP GET', 'span has wrong name');
+          assert.strictEqual(span.name, 'GET', 'span has wrong name');
         });
 
         it('span should have correct kind', () => {