Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

chore: remove nycrc in favor of tsconfig reporting #8

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Feb 23, 2021

The nycrc file was causing the coverage reports to include a bunch of files we don't necessarily want. Removing it allows the tsconfig to be used which is actually the important coverage of the project.

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #8 (92b4431) into main (53244ed) will increase coverage by 4.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   89.82%   94.27%   +4.45%     
==========================================
  Files          33       35       +2     
  Lines         452      489      +37     
  Branches       77       78       +1     
==========================================
+ Hits          406      461      +55     
+ Misses         46       28      -18     
Impacted Files Coverage Δ
backwards-compatability/node8/index.ts
backwards-compatability/node12/index.ts
backwards-compatability/node10/index.ts
scripts/version-update.js
src/index.ts 100.00% <0.00%> (ø)
src/platform/browser/index.ts 100.00% <0.00%> (ø)
src/platform/node/index.ts 100.00% <0.00%> (ø)
karma.conf.js 100.00% <0.00%> (ø)
src/platform/index.ts 100.00% <0.00%> (ø)
src/platform/browser/globalThis.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53244ed...92b4431. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants