Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

feat(context): add utils method to remove keys from context #66 #69

Merged
merged 2 commits into from
May 21, 2021
Merged

feat(context): add utils method to remove keys from context #66 #69

merged 2 commits into from
May 21, 2021

Conversation

vmarchaud
Copy link
Member

@vmarchaud vmarchaud self-assigned this May 15, 2021
@vmarchaud vmarchaud force-pushed the delete-from-context-methods branch from 54653ec to 7d2fe8c Compare May 15, 2021 14:32
@codecov
Copy link

codecov bot commented May 15, 2021 •
edited
Loading

Codecov Report

Merging #69 (388d3af) into main (77b8c34) will decrease coverage by 0.29%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   95.00%   94.70%   -0.30%     
==========================================
  Files          42       42              
  Lines         561      567       +6     
  Branches       94       94              
==========================================
+ Hits          533      537       +4     
- Misses         28       30       +2
Impacted Files Coverage Δ
src/baggage/context-helpers.ts 87.50% <50.00%> (-12.50%) ⬇️
src/trace/context-utils.ts 92.85% <50.00%> (-7.15%) ⬇️
src/api/propagation.ts 100.00% <100.00%> (ø)
src/api/trace.ts 96.66% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77b8c34...388d3af. Read the comment docs.

Flarna
Flarna reviewed May 15, 2021
View reviewed changes
src/api/trace.ts Outdated Show resolved Hide resolved
@vmarchaud vmarchaud force-pushed the delete-from-context-methods branch from 7d2fe8c to 388d3af Compare May 21, 2021 07:43
@vmarchaud vmarchaud requested a review from Flarna May 21, 2021 07:47
obecny
obecny approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dyladan dyladan merged commit e1745d1 into open-telemetry:main May 21, 2021
@dyladan dyladan added the enhancement New feature or request label May 21, 2021
@dyladan dyladan mentioned this pull request May 21, 2021
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 22, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@obecny obecny obecny approved these changes

@dyladan dyladan dyladan approved these changes

@Flarna Flarna Flarna approved these changes

@johnbley johnbley Awaiting requested review from johnbley

@legendecas legendecas Awaiting requested review from legendecas

@markwolff markwolff Awaiting requested review from markwolff

@mayurkale22 mayurkale22 Awaiting requested review from mayurkale22

@mwear mwear Awaiting requested review from mwear

@naseemkullah naseemkullah Awaiting requested review from naseemkullah

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

Assignees

@vmarchaud vmarchaud

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improv: add context utils to delete span/baggage from context
4 participants
@vmarchaud @obecny @dyladan @Flarna