Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

chore: release 1.2.0 #171

Merged
merged 1 commit into from
Aug 18, 2022
Merged

chore: release 1.2.0 #171

merged 1 commit into from
Aug 18, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Aug 9, 2022

🤖 I have created a release *beep* *boop*

1.2.0 (2022-08-09)

Features


This PR was generated with Release Please. See documentation.

@dyladan dyladan requested a review from a team August 9, 2022 14:06
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #171 (3dcb9cf) into main (313b2e2) will not change coverage.
The diff coverage is n/a.

❗ Current head 3dcb9cf differs from pull request most recent head f49e0e4. Consider uploading reports for the commit f49e0e4 to get more accurate results

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files          45       45           
  Lines         650      650           
  Branches      102      102           
=======================================
  Hits          619      619           
  Misses         31       31           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dyladan
Copy link
Member Author

dyladan commented Aug 9, 2022

@open-telemetry/javascript-maintainers this would require the latest SDK in oder to be used because the minor version is updated. Should we instead release this as 1.1.1? It is not a bug fix, but it is strictly compatible with the previous SDK version.

@dyladan
Copy link
Member Author

dyladan commented Aug 9, 2022

Lint check fails because the link to the release is broken until the release is made.

@Flarna
Copy link
Member

Flarna commented Aug 9, 2022

Should we instead release this as 1.1.1?

Why should we violate semver? If some instrumentation uses the new API it should depend on 1.2.0 to clearly indicated that it can't work with 1.1.x.

There is compatibility with old SDK but not with old API.

@legendecas
Copy link
Member

legendecas commented Aug 9, 2022

I have no good argument to break the semver semantics.

Notably, in our docs, we always ignore the patch bit in the semver: https://github.com/open-telemetry/opentelemetry-js#compatibility-matrix. I found @Flarna's point is fair.

@dyladan
Copy link
Member Author

dyladan commented Aug 9, 2022

OK sounds good

@dyladan dyladan merged commit d2fb706 into main Aug 18, 2022
@dyladan
Copy link
Member Author

dyladan commented Aug 18, 2022

🤖 Release is at https://github.com/open-telemetry/opentelemetry-js-api/releases/tag/v1.2.0 🌻

@cartermp
Copy link
Contributor

@dyladan what are the next steps here? The API docs we point people towards are up to date w.r.t. 1.2: https://open-telemetry.github.io/opentelemetry-js-api/interfaces/tracer.html

But there's no corresponding 1.2 package on npmjs that people can use.

@dyladan
Copy link
Member Author

dyladan commented Aug 23, 2022

@cartermp
Copy link
Contributor

Heh, whoopsie. Hmm. Weird that it doesn't pop up when I search for it? https://www.npmjs.com/package/@opentelemetry/api (points to 1.1 for me)

@dyladan
Copy link
Member Author

dyladan commented Aug 23, 2022

1.2 has the next tag until open-telemetry/opentelemetry-js#3192 is merged and released in order to avoid a situation where the latest API and SDK are not compatible.

@dyladan
Copy link
Member Author

dyladan commented Aug 23, 2022

We're discussing merging the API and SDK repositories back into a single repo so we can link everything with lerna and release all at once in order to avoid this issue in the future. It will also help with developing new API features.

@cartermp
Copy link
Contributor

Awesome, thank you! I will track that for now (my intent is to update docs for both otel and honeycomb once this is in place).

@cartermp
Copy link
Contributor

👋🏻 noticed everything's been merged and released - is there anything else needed to get the tag updated for the API package?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants