Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure periodic metric reader interval with otel.metric.export.interval #3840

Merged

Conversation

jack-berg
Copy link
Member

Updating autoconfigure configuration of the periodic metric reader to be based off otel.metric.export.interval, and deprecating otel.imr.export.interval.

This system property was introduced in spec PR 2038.

The spec also introduced another property, OTEL_METRIC_EXPORT_TIMEOUT, but PeriodicMetricReader doesn't yet have a configurable export timeout.

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #3840 (5170d5e) into main (4e38ab3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3840      +/-   ##
============================================
+ Coverage     89.19%   89.22%   +0.02%     
- Complexity     4039     4041       +2     
============================================
  Files           486      486              
  Lines         12524    12526       +2     
  Branches       1221     1222       +1     
============================================
+ Hits          11171    11176       +5     
- Misses          933      934       +1     
+ Partials        420      416       -4     
Impacted Files Coverage Δ
...sdk/autoconfigure/MetricExporterConfiguration.java 84.28% <100.00%> (+0.46%) ⬆️
...emetry/api/baggage/propagation/PercentEscaper.java 79.69% <0.00%> (-4.52%) ⬇️
...ntelemetry/sdk/extension/resources/OsResource.java 90.69% <0.00%> (+4.65%) ⬆️
...ava/io/opentelemetry/sdk/internal/RateLimiter.java 100.00% <0.00%> (+5.88%) ⬆️
...metry/sdk/extension/resources/ProcessResource.java 87.50% <0.00%> (+6.25%) ⬆️
...elemetry/sdk/extension/resources/HostResource.java 92.30% <0.00%> (+15.38%) ⬆️
...dk/extension/resources/ProcessRuntimeResource.java 100.00% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e38ab3...5170d5e. Read the comment docs.

@anuraaga anuraaga merged commit 4b7e509 into open-telemetry:main Nov 9, 2021
This was referenced Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants