Returns invalid traceflags for a bad string parse instead of throwing… #2937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… an exception.
Supercedes #2869
This removes the one and only place in the API that still declares it throws an exception. It avoids returning
null
, as in #2869, to reduce the chance of problems with usage of the API, an invalid traceflags should be handled by a propagator. But in the chance it's not handled, it will act as an empty traceflags and not cause crashes.This is a behavior change which I agree with @bogdandrutu we need to make now or never since, i.e. a propagator that relied on the exceptions to handle invalid would not do so anymore if we removed them later. As
TraceFlags
presumably has no real use case outside of the w3c propagator, I'm comfortable with squeezing this into the release but open to thoughts.