Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpClient 4.0 java tests #7912

Merged

Conversation

anuragagarwal561994
Copy link
Contributor

@anuragagarwal561994 anuragagarwal561994 commented Feb 26, 2023

Converts apache-httpclient-4.0 unit tests in java. Version 4.0 was using GuardedBy annotation which was interfering with the test cases, hence the library version was shifted to 4.1. #7195

@anuragagarwal561994 anuragagarwal561994 requested a review from a team February 26, 2023 12:02
Comment on lines 27 to 28
// 4.0.x uses GuardedBy which interferes with compiling tests
library("org.apache.httpcomponents:httpclient:4.1")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try this:

Suggested change
// 4.0.x uses GuardedBy which interferes with compiling tests
library("org.apache.httpcomponents:httpclient:4.1")
library("org.apache.httpcomponents:httpclient:4.0")
testCompileOnly("net.jcip:jcip-annotations:1.0")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @trask this works, thanks.

@trask trask merged commit 7bb978d into open-telemetry:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants