Update (rewrite) the javaagent structure doc; document bootstrap modules #6227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-99
to
-100
|  | ||
| [Image source](https://docs.google.com/drawings/d/1GHAcJ8AOaf_v2Ip82cQD9dN0mtvSk2C1B11KfwV2U8o) |
There was a problem hiding this comment.
I removed the initialization sequence doc from the new version of this page: it was completely out of date, and I don't think it was that useful -- the overall structure/architecture of the javaagent is very useful for a contributor (I think? it's not like I have anything to back this up 😅 ), but the initialization sequence is something that is changed very rarely. If you really need to know you can just read the code, it's not that hard to follow (unlike the structure, where you need to learn what every top-level module does, and which CL it's loaded by)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4286