Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Vibur DBCP connection pool metrics #6092

Merged
merged 5 commits into from
May 26, 2022

Conversation

laurit
Copy link
Contributor

@laurit laurit commented May 25, 2022

No description provided.

@laurit laurit requested a review from a team May 25, 2022 12:52
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

instrumentation/vibur-dbcp-11.0/library/README.md Outdated Show resolved Hide resolved
Comment on lines +37 to +38
metrics.usedConnections(() -> dataSource.getPool().taken()),
metrics.idleConnections(() -> dataSource.getPool().remainingCreated()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may want to rethink the DbConnectionPoolMetrics API after batch recording is available in 1.15.0

@laurit laurit merged commit b95b64b into open-telemetry:main May 26, 2022
@laurit laurit deleted the vibur-metrics branch May 26, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants