Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Config & ConfigBuilder API #5733

Merged
merged 4 commits into from
Apr 6, 2022

Conversation

mateuszrzeszutek
Copy link
Member

Deprecated a few methods that should not live in instrumentation-api, renamed a couple of methods so that they follow the general builder naming conventions (i.e. "read" -> "add")

@mateuszrzeszutek mateuszrzeszutek requested a review from a team April 1, 2022 10:00
Comment on lines -23 to +16
Config.get()
.isInstrumentationPropertyEnabled(
instrumentationNames(), "item.enabled", /* defaultEnabled= */ false);
Config.get().getBoolean("otel.instrumentation.spring-batch.item.enabled", false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit 65717da into open-telemetry:main Apr 6, 2022
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
* Cleanup Config & ConfigBuilder API

* errorprone

* errorprone & spotless

* spotless
@mateuszrzeszutek mateuszrzeszutek deleted the cleanup-config-api branch November 18, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants