add NetRpcClientAttributesExtractor and NetRpcServerAttributesExtractor #4948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangtaoran
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
|
hey @yangtaoran, sorry for the delay. since this would affect rpc span attributes as well, we should probably wait a bit for more confirmation about the proposed spec change. is there a particular issue you are wanting to resolve in the short-term? |
|
hi @yangtaoran! a lot of things have changed in the AttributeExtractor design and implementations since you opened this PR, can you let us know if you still need it? |
|
hi @yangtaoran! a lot of things have changed in the AttributeExtractor design and implementations since you opened this PR, can you let us know if you still need the PR or if it's not needed anymore? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to open-telemetry/opentelemetry-specification#2214 rpc client net metrcis attributes should keep up with https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/rpc.md#attributes.And the rpc server net metrcis attributes should be net.host.name,net.host.ip,net.transport.