Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop/rmi instrumentation #4764

Merged

Conversation

Samudraneel24
Copy link
Contributor

  • Removing the top level span check as discussed.
  • Changing extendsClass(named("java.rmi.server.RemoteServer")) to implementsInterface(named("java.rmi.Remote")) because any remote object must directly or indirectly implement the Remote interface. So this matcher covers a larger set of possible remote object implementations.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 1, 2021

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Samudraneel24!

@trask trask merged commit 1ff51fb into open-telemetry:main Dec 1, 2021
@Samudraneel24 Samudraneel24 deleted the develop/rmi-instrumentation branch December 2, 2021 03:53
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
* Remove new top level client span check from UnicastRefInstrumentation.java

* Instrument Remote instead of RemoteServer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants