Add span names cache #4004
Merged
Add span names cache #4004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
anuraaga
reviewed
Aug 29, 2021
| import java.lang.reflect.Method; | ||
| import org.checkerframework.checker.nullness.qual.Nullable; | ||
|
|
||
| public final class SpanNames { | ||
|
|
||
| private static final ClassValue<Cache<String, String>> spanNameCaches = |
There was a problem hiding this comment.
Can you check whether instrumentation have their own cache to not double cache?
There was a problem hiding this comment.
sure, just looked through all callers, didn't find any secondary caches
| new ClassValue<Cache<String, String>>() { | ||
| @Override | ||
| protected Cache<String, String> computeValue(Class<?> clazz) { | ||
| // should be naturally bounded, but setting a limit just in case |
There was a problem hiding this comment.
This seems pretty safe to me I'd probably just use ConcurrentHashMap. I think I've seen us using it in other similar caches
anuraaga
approved these changes
Aug 29, 2021
mateuszrzeszutek
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.