Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Config#create() method and use builder everywhere #3338

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

mateuszrzeszutek
Copy link
Member

Config#create() does not normalize property names, which could cause some confusion when writing tests. Now it was made private and ConfigBuilder is used everywhere to create Config instances.

Also added a Config#getLongProperty() that might be useful for vendor distros.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 16, 2021

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove/deprecate Config.asJavaProperties() now that getAllProperties() is public?

@mateuszrzeszutek
Copy link
Member Author

Can we remove/deprecate Config.asJavaProperties() now that getAllProperties() is public?

Unfortunately I can't remove it (it's still used in e.g. SpanExporterFactory, which is deprecated by the way), but it definitely should be deprecated 👍

@trask trask merged commit 0a8907d into open-telemetry:main Jun 17, 2021
@mateuszrzeszutek mateuszrzeszutek deleted the config-improvements branch June 18, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants