Improve Akka instrumentation #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
ghost
approved these changes
Apr 6, 2021
| @@ -34,6 +38,7 @@ public AkkaActorInstrumentationModule() { | |||
| map.put(Runnable.class.getName(), State.class.getName()); | |||
| map.put(Callable.class.getName(), State.class.getName()); | |||
| map.put(AkkaForkJoinTaskInstrumentation.TASK_CLASS_NAME, State.class.getName()); | |||
| map.put("akka.dispatch.Envelope", State.class.getName()); | |||
There was a problem hiding this comment.
Why not "Envelope.class.getName()" ? AFAIK the class is available for reference at this point. Not that it changes a lot ;)
There was a problem hiding this comment.
Actually the class isn't available. InstrumentationModule instances are loaded by AgentClassLoader so they can only see what jdk has and the things that are bundled inside agent.
mateuszrzeszutek
approved these changes
Apr 6, 2021
trask
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attach context to Akka message and restore it before invoking target method to ensure it runs with correct parent context.