Support faas.id & cloud.account.id attributes in AWS Lambda #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
trask and
tylerbenson
as code owners
anuraaga
reviewed
Dec 7, 2020
...0/library/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/AwsLambdaTracer.java
Show resolved
Hide resolved
...0/library/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/AwsLambdaTracer.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
force-pushed
the
support-faas-id-attribute-in-aws-lambda
branch
from
8f048fc
to
45b2625
Compare
anuraaga
approved these changes
Dec 8, 2020
...0/library/src/main/java/io/opentelemetry/instrumentation/awslambda/v1_0/AwsLambdaTracer.java
Outdated
Show resolved
Hide resolved
bhautikpip
pushed a commit
to bhautikpip/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 18, 2020
…emetry#1831) * Support faas.id & cloud.account.id attributes in AWS Lambda * Cache accountId * Cache accountId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1773 (this is the last thing that I wanted to support)
It probably needs to wait for the spec PR open-telemetry/opentelemetry-specification#1265 to get merged.