Fix vert.x route containing dupicate segments when RoutingContext.next is used #12260
+131
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Sep 16, 2024
| return holder != null ? holder.route : null; | ||
| } | ||
|
|
||
| public static void set(Context context, String route) { |
There was a problem hiding this comment.
There are similar set methods in other ImplicitContextKeyed implementations. If we are going to rename then we should rename all the similar usages and probably the get method also. I think the holder != null check is just defensive coding. It really should not be null unless the instrumented code has changed in an unexpected way, so the IfExists suffix isn't really necessary in my opinion.
| this.route = route; | ||
| } | ||
|
|
||
| public static Context with(Context context, String route) { |
There was a problem hiding this comment.
renamed to init because init is in a couple of other ImplicitContextKeyed implementations
jaydeluca
approved these changes
Sep 17, 2024
heyams
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully resolves #12234