Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken delegation for global meterproviders (#5827) #5828

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jesse-Bonfire
Copy link

Fixed broken delegation for global meterproviders (#5827)

Copy link

CLA Not Signed

@dashpole
Copy link
Contributor

Can you add a unit test that fails before the fix, and passes after?

@dmathieu
Copy link
Member

You will also need to sign the CLA.

@Jesse-Bonfire
Copy link
Author

Working with my company to get CLA approval. Also where should I put the unit test? internal/global/meter_test.go or is there a better spot?

@dashpole
Copy link
Contributor

internal/global/meter_test.go is great

@blkt
Copy link

blkt commented Sep 20, 2024

Hello folks, sorry to jump in, @MrAlias kindly pointed me to this PR while discussing a problem I had with the recent release of opentelemetry.

While this fix indeed solves the broken delegation problem in our case, the setup we have had the system panicking because it went through this line of code which is not followed by a return like similar occurrences, like this and this.
As a result, it ran reg.Unregister with a null pointer.

Since the code has been there for a while I assume this is the desired behavior, but it does look suspicious to me, so I wanted to put this on your radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants