Implement the BatchingProcessor without polling #5107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BatchingProcessor is not expected to ultimately contain configuration fields for queue size or export parameters (see open-telemetry#5093). This will break TestNewBatchingProcessorConfiguration which tests the configuration by evaluating the BatchingProcessor directly. Instead, test the batchingConfig and rename the test to TestNewBatchingConfig to match what is being tested.
MrAlias
added
area:logs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5107 +/- ##
=======================================
- Coverage 83.8% 83.8% -0.1%
=======================================
Files 248 248
Lines 16230 16382 +152
=======================================
+ Hits 13602 13729 +127
- Misses 2340 2360 +20
- Partials 288 293 +5
|
pellared
reviewed
Mar 26, 2024
sdk/log/batch.go
Outdated
Comment on lines
120
to
121
| // Cancel all exports and polling. | ||
| b.cancel() |
There was a problem hiding this comment.
I am not sure why we should cancel pending exports. I think we should still give a chance to have them completed until export timeout is not reached. Cannot this lead to missing log records?
There was a problem hiding this comment.
This cancels the context for the polling. This is not the context used in the last flush.
There was a problem hiding this comment.
Suggested change
| // Cancel all exports and polling. | |
| b.cancel() | |
| // Cancel all subsequent exports and polling. | |
| b.cancel() |
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #5106 (this includes a cherry-pick of that PRs commit)
The batching log processor provides the base functionality where it batches received records to a configured limit and then exports them. It also provides "polling" functionality where record batches beyond certain time-limit are exported. This change implements the former.
OnEmitis implemented batch and flush when a full queue is reached. TheForceFlushandShutdownmethods are implemented to appropriately interact with this functionality.The actual exporting functionality is stubbed until #5104 and #5105 are merged.
The addition of polling is planned for a follow up PR. See #5093 for how this will be extended to include polling.
Part of #5063