only sort maps, not slices

open-telemetry · May 8, 2024 · 7d4fe30 · 7d4fe30
1 parent cc6e48e
commit 7d4fe30
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 13 deletions.
diff --git a/log/keyvalue.go b/log/keyvalue.go
@@ -255,15 +255,7 @@ func (v Value) Equal(w Value) bool {
 	case KindFloat64:
 		return v.asFloat64() == w.asFloat64()
 	case KindSlice:
-		sv := v.asSlice()
-		sw := w.asSlice()
-		slices.SortFunc(sv, func(a, b Value) int {
-			return cmp.Compare(a.String(), b.String())
-		})
-		slices.SortFunc(sw, func(a, b Value) int {
-			return cmp.Compare(a.String(), b.String())
-		})
-		return slices.EqualFunc(sv, sw, Value.Equal)
+		return slices.EqualFunc(v.asSlice(), w.asSlice(), Value.Equal)
 	case KindMap:
 		sv := v.asMap()
 		slices.SortFunc(sv, func(a, b KeyValue) int {

diff --git a/log/keyvalue_test.go b/log/keyvalue_test.go
@@ -75,10 +75,6 @@ func TestSortedValueEqual(t *testing.T) {
 		value  log.Value
 		value2 log.Value
 	}{
-		{
-			value:  log.SliceValue(log.IntValue(3), log.StringValue("foo")),
-			value2: log.SliceValue(log.StringValue("foo"), log.IntValue(3)),
-		},
 		{
 			value: log.MapValue(
 				log.Slice("l", log.IntValue(3), log.StringValue("foo")),