-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Microsoft.AspNetCore.Http.Abstractions for netcoreapp3.1 and higher #1917
Drop Microsoft.AspNetCore.Http.Abstractions for netcoreapp3.1 and higher #1917
Conversation
src/OpenTelemetry.Instrumentation.AspNetCore/OpenTelemetry.Instrumentation.AspNetCore.csproj
Show resolved
Hide resolved
@trejjam This is an interesting idea! I have only seen the end-of-line applications reference |
.NET has published guidelines on this here : https://docs.microsoft.com/en-us/aspnet/core/fundamentals/target-aspnetcore?view=aspnetcore-5.0&tabs=visual-studio |
@trejjam Sorry for coming back so late. Would you have time to resolve the conflicts in this PR, so we can take this forward? the change looks good and is in alignment with that .NET guidelines. |
Yes, I will resolve it. |
4615516
to
318f6a0
Compare
@cijothomas Done |
4047d80
to
01d19a7
Compare
Hello @cijothomas, can you review it? |
Codecov Report
@@ Coverage Diff @@
## main #1917 +/- ##
=======================================
Coverage 85.10% 85.10%
=======================================
Files 187 187
Lines 6075 6075
=======================================
Hits 5170 5170
Misses 905 905
|
Changes
This PR handle issue with dependency restoring for .NetCore 3.1 and higher. There is no
Microsoft.AspNetCore.Http.Abstractions
after .NetCore 2.2. TheHttp.Abstraction
requires other v2.x packages, which causes resolving issues for newer frameworks.