Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Microsoft.AspNetCore.Http.Abstractions for netcoreapp3.1 and higher #1917

Merged

Conversation

trejjam
Copy link
Contributor

@trejjam trejjam commented Mar 17, 2021

Changes

This PR handle issue with dependency restoring for .NetCore 3.1 and higher. There is no Microsoft.AspNetCore.Http.Abstractions after .NetCore 2.2. The Http.Abstraction requires other v2.x packages, which causes resolving issues for newer frameworks.

@trejjam trejjam requested a review from a team March 17, 2021 11:40
@CodeBlanch
Copy link
Member

@trejjam This is an interesting idea! I have only seen the end-of-line applications reference Microsoft.AspNetCore.App. Is this a common thing done by libraries? Do you have any favorite examples doing the same thing we could check out?

@trejjam
Copy link
Contributor Author

trejjam commented Mar 19, 2021

@cijothomas
Copy link
Member

@cijothomas
Copy link
Member

@trejjam Sorry for coming back so late. Would you have time to resolve the conflicts in this PR, so we can take this forward? the change looks good and is in alignment with that .NET guidelines.

@trejjam
Copy link
Contributor Author

trejjam commented Jun 2, 2021

Yes, I will resolve it.

@trejjam trejjam force-pushed the feature/drop-net-core-2-dependencies branch from 4615516 to 318f6a0 Compare June 7, 2021 10:48
@trejjam
Copy link
Contributor Author

trejjam commented Jun 7, 2021

@cijothomas Done

@trejjam trejjam force-pushed the feature/drop-net-core-2-dependencies branch from 4047d80 to 01d19a7 Compare June 22, 2021 08:04
@trejjam
Copy link
Contributor Author

trejjam commented Jun 22, 2021

Hello @cijothomas, can you review it?

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #1917 (0df928d) into main (db6dc75) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1917   +/-   ##
=======================================
  Coverage   85.10%   85.10%           
=======================================
  Files         187      187           
  Lines        6075     6075           
=======================================
  Hits         5170     5170           
  Misses        905      905           
Impacted Files Coverage Δ
...ion.AspNetCore/AspNetCoreInstrumentationOptions.cs 100.00% <ø> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs 86.42% <ø> (ø)
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 95.34% <0.00%> (-0.78%) ⬇️
...penTelemetry/Internal/ServiceProviderExtensions.cs 100.00% <0.00%> (+33.33%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants