Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] + [paymentservice] - update JS SDKs #853

Merged
merged 4 commits into from
Apr 28, 2023
Merged

[frontend] + [paymentservice] - update JS SDKs #853

merged 4 commits into from
Apr 28, 2023

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Apr 26, 2023

Changes

Fixes: #826

Updates the JS SDKs to the latest. Allows us to remove the filter processor in the collector. This change also configures the instrumentation-fs library to only instrument calls when part of another trace. This was required because that library would generate hundreds/thousands of single-span traces on startup.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck puckpuck requested a review from a team April 26, 2023 12:52
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck
Copy link
Contributor Author

I need to update docs for this as well since the instrumentation code has changed for both services. I will get to that in the next day.

@julianocosta89 julianocosta89 added the docs-update-required Requires documentation update label Apr 26, 2023
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just a comment, but not a blocker

CHANGELOG.md Show resolved Hide resolved
@puckpuck puckpuck added the helm-update-required Requires an update to the Helm chart when released label Apr 27, 2023
@mviitane
Copy link
Member

Allows us to remove the filter processor in the collector.

@puckpuck, you mean transform processor?

Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I got rid of these printouts when starting frontend in docker:

frontend  | Accessing resource attributes before async attributes settled
frontend  | Process is not running on K8S [Error: ENOENT: no such file or directory, access '/var/run/secrets/kubernetes.io/serviceaccount/token'] {
frontend  |   errno: -2,
frontend  |   code: 'ENOENT',
frontend  |   syscall: 'access',
frontend  |   path: '/var/run/secrets/kubernetes.io/serviceaccount/token'
frontend  | }
frontend  | Dropped 277266 spans because maxQueueSize reached
frontend  | Dropped 38851 spans because maxQueueSize reached
frontend  | npm notice 
frontend  | npm notice New minor version of npm available! 9.5.1 -> 9.6.5
frontend  | npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.5>
frontend  | npm notice Run `npm install -g npm@9.6.5` to update!
frontend  | npm notice 

@puckpuck puckpuck merged commit 471204e into open-telemetry:main Apr 28, 2023
@puckpuck puckpuck deleted the update_js_sdks branch April 28, 2023 14:04
AlexanderWert pushed a commit to AlexanderWert/opentelemetry-demo that referenced this pull request Jul 24, 2023
* update JS SDKs

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* only use instrumentation-fs when part of a trace

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* update js SDKS

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

---------

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* update JS SDKs

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* only use instrumentation-fs when part of a trace

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* update js SDKS

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

---------

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-update-required Requires documentation update helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove filter processor when #18194 from collector-contrib is resolved
3 participants