Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource Detectors to payment service #651

Merged

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Dec 21, 2022

Changes

Like #648 this will add resource detectors to the payment service, to create richer data for the backend, e.g.:

Screenshot 2022-12-21 at 12 45 52

Merge Requirements

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs folder

Signed-off-by: svrnm <neumanns@cisco.com>
@svrnm svrnm requested a review from a team December 21, 2022 11:46
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: svrnm <neumanns@cisco.com>
@fatsheep9146
Copy link
Contributor

please fix conflicts, lgtm :)

@puckpuck puckpuck merged commit c5e8196 into open-telemetry:main Dec 24, 2022
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* Add Resource Detectors to payment service

Signed-off-by: svrnm <neumanns@cisco.com>

* Update CHANGELOG

Signed-off-by: svrnm <neumanns@cisco.com>

* Update src/paymentservice/package.json

Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com>

Signed-off-by: svrnm <neumanns@cisco.com>
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com>
Co-authored-by: Pierre Tessier <pierre@pierretessier.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants