Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency service #1714

Closed
wants to merge 27 commits into from
Closed

Currency service #1714

wants to merge 27 commits into from

Conversation

randax
Copy link

@randax randax commented Sep 2, 2024

instrumentation assignment

@randax randax requested a review from a team September 2, 2024 22:55
Copy link

CLA Missing ID CLA Not Signed

@github-actions github-actions bot added the docs-update-required Requires documentation update label Sep 2, 2024
@github-actions github-actions bot requested a review from trask September 2, 2024 22:55
@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Sep 2, 2024
@randax randax closed this Sep 2, 2024
@randax randax deleted the currency-service branch September 2, 2024 23:02
@julianocosta89
Copy link
Member

Hey @randax, it's nice to see that you have built a workshop with the demo ⭐ !
I quickly had a look over it, just out of curiosity and noticed that you are using the old version of docker compose.

In the instructions you are mentioning docker-compose, the new version doesn't use the -.
To make sure all the environment variables are properly populated I'd suggest using the latest version of docker compose.
The sintax is basically the same, just remove the - and you are good to go:

docker compose [COMMAND]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-update-required Requires documentation update helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants