[tests] - optimize trace testing #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
helm-update-required
puckpuck
removed
the
helm-update-required
github-actions
bot
added
the
helm-update-required
rogercoll
approved these changes
Jul 8, 2024
cedricziel
approved these changes
Jul 8, 2024
eliasmueller
pushed a commit
to UST-DeMAF/opentelemetry-demo
that referenced
this pull request
Jul 14, 2024
* optimize trace testing * run trace based tests concurrently * fix lint failures --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
ahealy-newr
pushed a commit
to ahealy-newr/opentelemetry-demo-ahealy
that referenced
this pull request
Jul 24, 2024
* optimize trace testing * run trace based tests concurrently * fix lint failures --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
CharlieTLe
added a commit
to CharlieTLe/opentelemetry.io
that referenced
this pull request
Sep 8, 2024
Optimizations on trace-based testing in open-telemetry/opentelemetry-demo#1659 changed how tracetest is enabled. This change updates the documentation to reflect on enabling trace based tests should be done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Significantly optimizes trace based testing going from 10 minutes to about 1 minute to run all tests. This was done by doing 3 main things:
This should help speed up going from an Approved PR to getting it merged, as waiting for a 10+ minute check to complete can lead to context switching.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additions* [ ] Appropriate documentation updates in the docs* [ ] Appropriate Helm chart updates in the helm-chartsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.