Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[adservice] - add manual tracing instrumentation #150

Merged
merged 5 commits into from
Jun 30, 2022
Merged

[adservice] - add manual tracing instrumentation #150

merged 5 commits into from
Jun 30, 2022

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Jun 17, 2022 •
edited
Loading

Fixes #60

  • Services extend automatic instrumentation.
    • New attributes/events attached to existing spans.
    • New spans are being created from existing spans.

Changes

Uses a mixture of adding spans and attributes using annotations, as well as manual creation of spans.
Attributes are added to existing auto-instrumented spans and newly created manual ones.

@puckpuck puckpuck requested a review from a team June 17, 2022 02:25
julianocosta89
julianocosta89 approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I've also deployed locally to ensure everything was compiling and working properly!
🚀 it!

austinlparker
austinlparker previously requested changes Jun 17, 2022
View reviewed changes
Copy link
Member

@austinlparker austinlparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, but I had some questions.

src/adservice/src/main/java/hipstershop/AdService.java Show resolved Hide resolved
src/adservice/src/main/java/hipstershop/AdService.java Show resolved Hide resolved
wph95
wph95 approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@wph95 wph95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just help authoer to fix PR describe todolist format
wrong

[x] xxxxx

- [x]  xxx

@cartersocha
Copy link
Contributor

@austinlparker, @mic-max any comments to Pierre's responses ?

@cartersocha
Copy link
Contributor

@puckpuck please update the branch & we can merge

@cartersocha cartersocha merged commit c533ecc into open-telemetry:main Jun 30, 2022
@puckpuck puckpuck deleted the puckpuck.ad-manual-instrumentation branch June 30, 2022 02:44
GaryPWhite pushed a commit to wayfair-contribs/opentelemetry-demo that referenced this pull request Jun 30, 2022
@puckpuck @GaryPWhite
[adservice] - add manual tracing instrumentation (open-telemetry#150)
d604239
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@puckpuck
[adservice] - add manual tracing instrumentation (open-telemetry#150)
9ee8b19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinlparker austinlparker austinlparker left review comments

@cartersocha cartersocha cartersocha left review comments

@wph95 wph95 wph95 approved these changes

@mic-max mic-max mic-max approved these changes

@julianocosta89 julianocosta89 julianocosta89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review and enhance tracing support for ad service service (Java)
6 participants
@puckpuck @cartersocha @wph95 @austinlparker @mic-max @julianocosta89