Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

currencyservice: bring back multistage build #1276

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

styblope
Copy link
Contributor

@styblope styblope commented Nov 27, 2023

Changes

This commit brings back the multistage docker build that was removed since #991

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • N/A Appropriate documentation updates in the docs
  • N/A Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@styblope styblope requested a review from a team November 27, 2023 10:26
@austinlparker
Copy link
Member

Hi - you will need to update this branch to pull changes. In the future, please do not make PRs from private forks or forks that we can't modify. (this needs to happen with the other PR you made as well)

@styblope
Copy link
Contributor Author

styblope commented Nov 29, 2023

sure, thanks for the reminder, will use my private repo next time, sorry about that.

src/currencyservice/Dockerfile Outdated Show resolved Hide resolved
@julianocosta89
Copy link
Member

@styblope please resolve the conflicts, and we should be good to merge this one

@austinlparker austinlparker merged commit 1bb3324 into open-telemetry:main Nov 29, 2023
27 checks passed
kabrol98 pushed a commit to deductive-ai/opentelemetry-demo that referenced this pull request Jan 24, 2024
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants