Add sdk-config.yaml starter template w/ references to env vars #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcalff
approved these changes
Mar 18, 2024
jack-berg
added a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Apr 5, 2024
…v var substitution default syntax (#3948) Fixes #3752. Implementation of the configuration working group recommendation as [described here](#3752 (comment)). - Adds definition for `OTEL_EXPERIMENTAL_CONFIG_FILE `, which ignores other env vars when evaluating, except env var substitution references - Adds new env var substitution default syntax `${ENVVAR:-defaultValue}` - Paired with open-telemetry/opentelemetry-configuration#76, which defines a new [sdk-config.yaml](https://github.com/jack-berg/opentelemetry-configuration/blob/starter-template/examples/sdk-config.yaml) starter template referencing all env vars that map cleanly.
jack-berg
force-pushed
the
starter-template
branch
from
d05a637
to
73cd03f
Compare
|
This is a loose end from open-telemetry/opentelemetry-specification#3948 I've pushed an additional commit and marked as ready for review. Please review when you have the chance. cc @open-telemetry/configuration-maintainers |
codeboten
reviewed
Apr 29, 2024
|
@tsloughter, @marcalff, @codeboten can you take another look? Thanks |
codeboten
approved these changes
Jul 9, 2024
|
@marcalff would appreciate you taking another look when you can. Thanks! |
marcalff
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #55.
Part of the configuration working group recommendation on how to move forward with #3752 as described here.
sdk-migration-config.yamlto the examples directory, which includes env var substitution references to all env vars which map cleanly to file configsdk-config.yamlto the example directory, which is identical tosdk-migration-config.yaml, but without env var substitution references