Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use generated meter #9669

Merged

Conversation

codeboten
Copy link
Contributor

This follows #9556 and uses the Meter func instead of managing the scope in the batch processor manually. Replaces #9581

This follows open-telemetry#9556 and uses the Meter func instead of managing the scope in the batch processor manually. Replaces open-telemetry#9581

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested review from a team and bogdandrutu March 1, 2024 19:12
@codeboten codeboten mentioned this pull request Mar 1, 2024
@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.94%. Comparing base (6affda6) to head (c731a6b).

Files Patch % Lines
processor/batchprocessor/metrics.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9669      +/-   ##
==========================================
+ Coverage   90.93%   90.94%   +0.01%     
==========================================
  Files         347      347              
  Lines       18344    18344              
==========================================
+ Hits        16681    16683       +2     
+ Misses       1340     1338       -2     
  Partials      323      323              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit c7f0172 into open-telemetry:main Mar 11, 2024
46 of 63 checks passed
@codeboten codeboten deleted the codeboten/use-generated-meter2 branch March 11, 2024 13:32
@github-actions github-actions bot added this to the next release milestone Mar 11, 2024
tomasmota pushed a commit to tomasmota/opentelemetry-collector that referenced this pull request Mar 14, 2024
This follows open-telemetry#9556 and uses the Meter func instead of managing the scope
in the batch processor manually. Replaces open-telemetry#9581

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants