Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move scraper error outside of phase1 stable packages #2580

Merged
merged 3 commits into from
Mar 8, 2021

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Mar 2, 2021

Remove all unstable types from packages that we plan to declare stable.

Updates #2476

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team March 2, 2021 23:20
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #2580 (efa59ab) into main (68871bd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2580   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files         273      273           
  Lines       15446    15446           
=======================================
  Hits        14215    14215           
  Misses        849      849           
  Partials      382      382           
Impacted Files Coverage Δ
receiver/scrapererror/partialscrapeerror.go 71.42% <ø> (ø)
obsreport/obsreport_scraper.go 100.00% <100.00%> (ø)
...eceiver/internal/scraper/cpuscraper/cpu_scraper.go 100.00% <100.00%> (ø)
...nternal/scraper/diskscraper/disk_scraper_others.go 100.00% <100.00%> (ø)
...al/scraper/filesystemscraper/filesystem_scraper.go 100.00% <100.00%> (ø)
...eiver/internal/scraper/loadscraper/load_scraper.go 100.00% <100.00%> (ø)
...r/internal/scraper/memoryscraper/memory_scraper.go 100.00% <100.00%> (ø)
...internal/scraper/networkscraper/network_scraper.go 97.91% <100.00%> (ø)
...nal/scraper/pagingscraper/paging_scraper_others.go 100.00% <100.00%> (ø)
...scraper/processesscraper/processes_scraper_unix.go 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68871bd...efa59ab. Read the comment docs.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the idea here? Remove all unstable types from packages that we plan to declare stable?

@bogdandrutu
Copy link
Member Author

@tigrannajaryan indeed I want all the packages that we plan to mark stable to have only stable code

@bogdandrutu bogdandrutu merged commit 65c4c4a into open-telemetry:main Mar 8, 2021
@bogdandrutu bogdandrutu deleted the mvscrapererr branch March 8, 2021 03:33
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
* Contributes to open-telemetry#2572

* Restored support for __builtin_expect()

* Typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants