add counter suffix test

Signed-off-by: naseemkullah <naseem@transit.app>
open-telemetry · Mar 8, 2021 · 69e31e7 · 69e31e7
1 parent a52e16e
commit 69e31e7
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 7 deletions.
diff --git a/exporter/prometheusremotewriteexporter/helper_test.go b/exporter/prometheusremotewriteexporter/helper_test.go
@@ -289,6 +289,12 @@ func Test_getPromMetricName(t *testing.T) {
 			ns1,
 			"test_ns_" + validIntSum + counterSuffix,
 		},
+		{
+			"already_has_total_suffix",
+			validMetrics1[validAptlyNamedIntSum],
+			ns1,
+			"test_ns_" + validAptlyNamedIntSum,
+		},
 		{
 			"dirty_string",
 			validMetrics2[validIntGaugeDirty],

diff --git a/exporter/prometheusremotewriteexporter/testutil_test.go b/exporter/prometheusremotewriteexporter/testutil_test.go
@@ -87,13 +87,14 @@ var (
 	quantileValues = []float64{7, 8, 9}
 	quantiles      = getQuantiles(quantileBounds, quantileValues)
 
-	validIntGauge        = "valid_IntGauge"
-	validDoubleGauge     = "valid_DoubleGauge"
-	validIntSum          = "valid_IntSum"
-	validDoubleSum       = "valid_DoubleSum"
-	validIntHistogram    = "valid_IntHistogram"
-	validDoubleHistogram = "valid_DoubleHistogram"
-	validDoubleSummary   = "valid_DoubleSummary"
+	validIntGauge         = "valid_IntGauge"
+	validDoubleGauge      = "valid_DoubleGauge"
+	validIntSum           = "valid_IntSum"
+	validAptlyNamedIntSum = "valid_IntSum_total"
+	validDoubleSum        = "valid_DoubleSum"
+	validIntHistogram     = "valid_IntHistogram"
+	validDoubleHistogram  = "valid_DoubleHistogram"
+	validDoubleSummary    = "valid_DoubleSummary"
 
 	validIntGaugeDirty = "*valid_IntGauge$"
 
@@ -136,6 +137,18 @@ var (
 				},
 			},
 		},
+		validAptlyNamedIntSum: {
+			Name: validAptlyNamedIntSum,
+			Data: &otlp.Metric_IntSum{
+				IntSum: &otlp.IntSum{
+					DataPoints: []*otlp.IntDataPoint{
+						getIntDataPoint(lbs1, intVal1, time1),
+						nil,
+					},
+					AggregationTemporality: otlp.AggregationTemporality_AGGREGATION_TEMPORALITY_CUMULATIVE,
+				},
+			},
+		},
 		validDoubleSum: {
 			Name: validDoubleSum,
 			Data: &otlp.Metric_DoubleSum{