Exclude 386 from opentelemetry-collector-contrib builds #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
force-pushed
the
mx-psi/exclude-i386
branch
from
54ab359
to
b129c5b
Compare
|
cc @jpkrohling can you take a look? |
jpkrohling
approved these changes
Mar 17, 2022
|
|
||
| distsFlag = flag.String("d", "", "Collector distributions(s) to build, comma-separated") | ||
| ) | ||
|
|
||
| func architecturesForDist(dist string) []string { | ||
| architectures := []string{"386", "amd64", "arm64"} | ||
| if dist == "otelcol-contrib" { |
There was a problem hiding this comment.
This is a good solution for this release and for the time being, but this would need to go into a config somewhere. I would even argue that we can remove 386 entirely, not only for the contrib. But we can have this discussion after this release :-)
There was a problem hiding this comment.
IMO reintroducing 386 is fine (since the additional effort to support it is small) but we need to have CI tests first on core and contrib to prevent issues like the one on this release (I created open-telemetry/opentelemetry-collector/issues/5031 and open-telemetry/opentelemetry-collector-contrib/issues/8544 to track this)
codeboten
pushed a commit
that referenced
this pull request
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: open-telemetry/opentelemetry-collector#5013 (comment)
We remove both Linux and Windows, since the issue affects all OSs.