Build ARM64 Docker images #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
approved these changes
Jan 11, 2022
This was referenced Jan 11, 2022
jpkrohling
approved these changes
Jan 12, 2022
| @@ -18,10 +18,20 @@ jobs: | |||
| with: | |||
| fetch-depth: 0 | |||
|
|
|||
| - name: Set up QEMU | |||
There was a problem hiding this comment.
That was the missing piece, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#39 added support for ARM + ARM64 multi-arch builds, but in #40 a project maintainer reported no longer being able to run goreleaser builds, and reverted it.
ARM(32) builds were removed from goreleaser entirely in #43, so this PR just adds back ARM64 Docker builds. It also updates the GitHub Actions workflows to install support for building the cross-architecture image, and updates the contributing docs with notes about how to set that up on a local system.