chore: add mysqlreceiver #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please rebase this one? There has been a release in between. |
|
@jpkrohling I will, but I guess it makes sense to wait for a confirmation from @djaglowski first? |
djaglowski
reviewed
Jan 10, 2022
|
Could you rebase this PR? |
vmihailenco
force-pushed
the
chore/mysqlreceiver
branch
from
346910b
to
fc0976b
Compare
|
@jpkrohling done, PTAL |
jpkrohling
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mysqlreceiver is available for few months and even has some integration tests added in open-telemetry/opentelemetry-collector-contrib#6916
I have been using the receiver for few days and everything seem to work fine - collector is stable and MySQL metrics are coming in.
Updates open-telemetry/opentelemetry-collector-contrib#6983