Improve the make experience. #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add checks for all the tools which are used by the build process. * Switch from `which` to `commmand` since ** `command` is a builtin to the shell. ** This also fixes an issue which was causing tools to be downloaded reguardless of whether it has been downloaded previously. Signed-off-by: Harold Dost <harolddost@gmail.com>
jpkrohling
approved these changes
Dec 20, 2021
|
@jpkrohling It looks like for some reason with both of my PRs the GoRelease workflow didn't run. Are you able to force it to run? |
|
Ah actually I think it's that didn't make a change to the GoReleaser, but that it's required for a merge to happen :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whichtocommmandsince**
commandis a builtin to the shell.** This also fixes an issue which was causing tools to be downloaded
reguardless of whether it has been downloaded previously.
Signed-off-by: Harold Dost harolddost@gmail.com