Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.39.0 release #33

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

codeboten
Copy link
Contributor

No description provided.

@codeboten codeboten requested review from a team and Aneurysm9 November 16, 2021 01:57
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be fine, but note that we seem to be using the builder v0.37.0 to build this:

OTELCOL_BUILDER_VERSION ?= 0.37.0

I ran goreleaser locally and it did work, but published the artifacts under my account:
https://github.com/jpkrohling/opentelemetry-collector/releases/tag/cmd/builder/v0.39.0

So, we have three options right now:

  1. Release it with the 0.37.0 builder (this PR) after doing a manual check
  2. Get the artifacts from my fork and manually upload to the 0.39.0 release and change this PR to use that. The builder repo has e2e tests, so, I'm sure it will work with the core 0.39.0
  3. Like options 2, but run goreleaser against the main repository to get the artifacts uploaded there. A maintainer of the core is likely needed for this.

@jpkrohling
Copy link
Member

I marked my review as "request changes" so that it's not accidentally merged without verifying the binaries manually. Once that happens, feel free to mark my review as dismissed.

@codeboten
Copy link
Contributor Author

This might be fine, but note that we seem to be using the builder v0.37.0 to build this:

OTELCOL_BUILDER_VERSION ?= 0.37.0

I ran goreleaser locally and it did work, but published the artifacts under my account: https://github.com/jpkrohling/opentelemetry-collector/releases/tag/cmd/builder/v0.39.0

So, we have three options right now:

1. Release it with the 0.37.0 builder (this PR) after doing a manual check

2. Get the artifacts from my fork and manually upload to the 0.39.0 release and change this PR to use that. The builder repo has e2e tests, so, I'm sure it will work with the core 0.39.0

3. Like options 2, but run goreleaser against the main repository to get the artifacts uploaded there. A maintainer of the core is likely needed for this.

Correct I'd updated the builder to use 0.39.0 to run into #34, which caused me to revert to 0.37.0. I thought we could release 0.39.0 and deal with the update to the builder after, but @jpkrohling you have more experience with the builder to know if this will be a problem or not. Happy to follow your recommendation here.

@codeboten
Copy link
Contributor Author

FWIW, i've manually tested the config in this repo with the builder I installed from the core repo running locally and found no problems.

@jpkrohling
Copy link
Member

Sounds good then! The only concern would have been if the bootstrap files are affected by breaking changes, namely in the go.opentelemetry.io/collector/component or go.opentelemetry.io/collector/service packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants