Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Add azuredataexplorerexporter in manifest (PR 12730) #210

Conversation

ag-ramachandran
Copy link
Contributor

No description provided.

@ag-ramachandran ag-ramachandran requested review from a team and mx-psi October 3, 2022 15:49
@jpkrohling
Copy link
Member

The build is currently failing. Please ping me again once you fix it.

@ag-ramachandran
Copy link
Contributor Author

ag-ramachandran commented Oct 4, 2022

@jpkrohling , Thanks for the review quick question. We had a new component released yesterday .

open-telemetry/opentelemetry-collector-contrib#12730

In this PR we have the following line.

github.com/open-telemetry/opentelemetry-collector-contrib/exporter/azuredataexplorerexporter v0.0.0-00010101000000-000000000000

Could the build be failing because of this? Would you know if we have to wait for the 0.6.2 release for this PR to have a passing build.

@jpkrohling
Copy link
Member

This is a common problem; take a look at recent similar PRs. There was one for the header setter extension that you could use as a reference.

@ag-ramachandran ag-ramachandran force-pushed the fix/add-adxremotesampling-exporter branch from 48d78e2 to 4631d0c Compare October 6, 2022 12:55
@codeboten
Copy link
Contributor

Looking at the header setter extension PR here it looks like the best way to move this forward may be to wait until the next release to include it (once the contrib repo v0.62.0 release is out)

codeboten pushed a commit to codeboten/opentelemetry-collector-releases that referenced this pull request Oct 13, 2022
Bump version numbers, added component from open-telemetry#210 as well.
codeboten pushed a commit that referenced this pull request Oct 13, 2022
Bump version numbers, added component from #210 as well.
@jpkrohling
Copy link
Member

Please rebase this, it should fix the CI issues.

@ag-ramachandran ag-ramachandran force-pushed the fix/add-adxremotesampling-exporter branch from d7f6b4b to c8ce357 Compare October 13, 2022 13:42
@ag-ramachandran
Copy link
Contributor Author

Thanks @jpkrohling rebased the changes with main.

@codeboten codeboten merged commit 671dd8f into open-telemetry:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants