-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-adding linux/ppc64le support #173
Conversation
@@ -27,7 +27,7 @@ jobs: | |||
- name: Setup QEMU | |||
uses: docker/setup-qemu-action@v2 | |||
with: | |||
platforms: arm64 | |||
platforms: arm64,ppc64le |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add in the readme, or in another place you find suitable, what needs to be done to add new platforms? This problem has happened already in the past with other platforms, and I think we could have prevented it if we had clear instructions on how to add new platforms.
@jpkrohling |
That would work, I believe |
@jpkrohling ADDING support for new platform/architecture
make generate-goreleaser
|
Yes, that's a good start. If we need, we can improve this doc in next iterations. |
@jpkrohling |
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@@ -63,3 +63,13 @@ This is accomplished by installing [qemu](https://www.qemu.org/), and then [enab | |||
apt-get install qemu binfmt-support qemu-user-static | |||
docker run --rm --privileged multiarch/qemu-user-static --reset -p yes | |||
``` | |||
|
|||
### Adding support for new platforms or architectures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reworded this a bit. Please take a look and give your approval. Once it's done, I think this is ready to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
please review and merge.