Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use git tags for 0.34.0 release #6

Closed
jpkrohling opened this issue Sep 1, 2021 · 1 comment · Fixed by #9
Closed

Use git tags for 0.34.0 release #6

jpkrohling opened this issue Sep 1, 2021 · 1 comment · Fixed by #9
Assignees
@jpkrohling

Comments

@jpkrohling
Copy link
Member

PR #4 set the versions to the SHA for the tag, but we should be using the tag instead. The SHA was being used before to track a specific unreleased commit and should not be used for the actual release.
@jpkrohling jpkrohling self-assigned this Sep 1, 2021
@bogdandrutu
Copy link
Member

The contrib was not released when I made the PR so I picked latest. Need a new PR to update to the tag

jpkrohling referenced this issue in jpkrohling/opentelemetry-collector-releases Sep 2, 2021
@jpkrohling
Use git tags for 0.34.0 release
ea5bc7c 
Fixes #6

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling mentioned this issue Sep 2, 2021
Merged
jpkrohling referenced this issue in jpkrohling/opentelemetry-collector-releases Sep 3, 2021
@jpkrohling
Use git tags for 0.34.0 release
de7cd2e 
Fixes #6

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
bogdandrutu pushed a commit that referenced this issue Sep 3, 2021
@jpkrohling
Use git tags for 0.34.0 release (#9)
b64379e 
* Use git tags for 0.34.0 release
Fixes #6

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Remove components that are in the core, fixed config.yaml

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpkrohling jpkrohling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use git tags for 0.34.0 release jpkrohling/opentelemetry-collector-releases
2 participants
@jpkrohling @bogdandrutu