[internal/stanza] Add support for []string in converter.go #9887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armstrmi
changed the title
djaglowski
changed the title
djaglowski
reviewed
May 10, 2022
CHANGELOG.md
Outdated
| @@ -51,6 +51,7 @@ | |||
| - `tanzuobservabilityexporter`: Make metrics stanza in config be optional (#9098) | |||
| - `filelogreceiver`: Update Kubernetes examples to fix native OTel logs collection issue where 0 length logs cause errors (#9754) | |||
| - `logstransformprocessor`: Resolve node ordering to fix intermittent failures (#9761) | |||
| - `stanzaconverterfix`: Add string array as possible type for converting log record entries (#9887) | |||
There was a problem hiding this comment.
The entry needs to refer to specific components. In this case, it affects several log receivers, so those should be enumerated.
Suggested change
| - `stanzaconverterfix`: Add string array as possible type for converting log record entries (#9887) | |
| - `filelog`, `journald`, `syslog`, `tcplog`, `udplog`: Add support for []string type for converting log record entries (#9887) |
djaglowski
approved these changes
May 10, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…metry#9887) * added fix to include string array type to converter * updated changelog * updated Changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing a bug - adding string array as possible type for converting log record entries and parsing them out
Link to tracking Issue:
Currently blocking this PR #9228
Testing:
Documentation: