[receiver/sqlserver] Do not pass metrics details to pkg/winperfcounters #9787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
refactor-sql-server-receiver
branch
10 times, most recently
from
e7191b5
to
92799a9
Compare
This is refactoring of the sqlserver receiver to make it use pkg/winperfcounters just to retrieve required pert counter values and do not pass metrics details back and forth. They are not needed there. This is one of the steps in bigger refactoring of the interface provided by pkg/winperfcounters.
dmitryax
force-pushed
the
refactor-sql-server-receiver
branch
from
92799a9
to
44a1620
Compare
djaglowski
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is refactoring of the sqlserver receiver to make it use pkg/winperfcounters just as a source of perf counter values and do not pass metric details back and forth.
pkg/winperfcountersuses user configuration structures fromwindowsperfcountersreceiver as its API interface which seems unnecessary. This is one of the steps in bigger refactoring to make thepkg/winperfcountersinterface concise and not dependent on user setting structures fromwindowsperfcountersreceiver.