[build] fix issue generator github action #9774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The github action for auto-generating issues when load tests are failing in main has been broken for some time. The check for branch was looking at the wrong branch name. Additionally the install command in the windows version was using an old go path.
|
With the load tests being so flaky recently, is this gonna make a lot of noise? Is it smart enough to know an issue is already open? |
pmm-sumo
approved these changes
May 8, 2022
There was a problem hiding this comment.
I think these are fair questions @TylerHelmuth Looking at the code it searches for the existing issues first
Since the action was there (just broken) I'm accepting it, but I guess if this is noisy we might want to revisit the policy
bogdandrutu
approved these changes
May 9, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
The github action for auto-generating issues when load tests are failing in main has been broken for some time. The check for branch was looking at the wrong branch name. Additionally the install command in the windows version was using an old go path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github action for auto-generating issues when load tests are failing in main has been broken for some time. The check for branch was looking at the wrong branch name. Additionally the install command in the windows version was using an old go path.