Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix errcheck failed issue for the files of e2e-test, demos and tools. #9769

Conversation

fatsheep9146
Copy link
Contributor

Description:
Fix errcheck issues. This PR focuses on the issues for the files of e2e-test, demos and tools.

Link to tracking Issue:
#9749

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
@fatsheep9146 fatsheep9146 requested a review from a team May 6, 2022 05:03
@fatsheep9146 fatsheep9146 changed the title Fatsheep9146/fix errcheck failed issue fix errcheck failed issue for the files of e2e-test, demos and tools. May 6, 2022
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 6, 2022
@codeboten codeboten merged commit 789297f into open-telemetry:main May 6, 2022
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this pull request May 10, 2022
…open-telemetry#9769)

* fix issue for examples/demo/server
* fix errcheck issue for testbed and tracegen
* fix govet error declaration of 'err' shadows declaration
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants