[Metric builder] Replace enum attributes values with typed constants #9683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
typed-attribute-values
branch
2 times, most recently
from
6f5cd94
to
9f521dd
Compare
dmitryax
force-pushed
the
typed-attribute-values
branch
from
9f521dd
to
59e3e90
Compare
`Record...DataPoint` functions should take one of predefined attribute values instead of any string if the attribute has enum field defined in metadata.yaml. This significantly reduces chance of passing wrong attribute values and helps to ensure accuracy of the automatically generated documentation.
dmitryax
force-pushed
the
typed-attribute-values
branch
from
59e3e90
to
5e8a6c9
Compare
|
@djaglowski rebased. PTAL |
|
Load test failures are unrelated to this PR |
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…pen-telemetry#9683) `Record...DataPoint` functions should take one of predefined attribute values instead of any string if the attribute has enum field defined in metadata.yaml. This significantly reduces chance of passing wrong attribute values and helps to ensure accuracy of the automatically generated documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record...DataPointfunctions should take one of predefined attribute values instead of any string if the attribute has enum field defined in metadata.yaml. This significantly reduces chance of passing wrong attribute values and helps to ensure accuracy of the automatically generated documentation.Resolves #9595
This PR includes changes from #9688 which should be merged first to avoid introducing any functional changes here