[exporter/azuremonitor] Drop reference to obsolete LogRecord.Name #9544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
reviewed
Apr 26, 2022
There was a problem hiding this comment.
please fix lint:
Error: log_to_envelope.go:29:2: `categoryNameTag` is unused (deadcode)
make[2]: *** [../../Makefile.Common:96: lint] Error 1
make[1]: *** [Makefile:163: for-all-target-./exporter/azuremonitorexporter] Error 2
make[1]: *** Waiting for unfinished jobs....
categoryNameTag = "CategoryName"
tigrannajaryan
approved these changes
Apr 26, 2022
pmm-sumo
approved these changes
Apr 27, 2022
|
There is a data race in one of the tests, unrelated to the change: https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6194147424?check_suite_focus=true |
|
Waiting for open-telemetry/opentelemetry-collector#5272 to be done to avoid test failures and then this will need a rebase. |
|
This is expected to fix the test #9564 |
|
@pcwiese please rebase from main. This should fix the build. |
pcwiese
force-pushed
the
pwiese/drop-logrecord-name
branch
from
9b8d61c
to
fe8909d
Compare
|
Thank you @pcwiese |
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…en-telemetry#9544) LogRecord.Name is obsolete and uses of it must be removed from this repo. Link to tracking Issue: open-telemetry#9258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
LogRecord.Name is obsolete and uses of it must be removed from this repo.
Link to tracking Issue:
#9258
Testing:
unit testing only.