Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datadog] Modify deprecation messages to reflect new plan #9422

Merged
merged 4 commits into from
Apr 25, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Apr 25, 2022

Description:

Modifies deprecation messages to be less specific.

Originally, we intended to remove deprecated settings/functionality in a staggered fashion, but we have decided to do them all at once in a future minor version. Because of this, the logs need to be modified to be less specific and state that the features will be removed on a given version 'or later'. Mentioning a specific version is still useful for end-users to understand that the feature won't be removed at least until that point.

Link to tracking Issue: #8372

@mx-psi mx-psi marked this pull request as ready for review April 25, 2022 11:49
@mx-psi mx-psi requested review from a team and dashpole April 25, 2022 11:49
@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Apr 25, 2022
@mx-psi
Copy link
Member Author

mx-psi commented Apr 25, 2022

Marking as 'ready to merge' since it has a codeowner approval.

@jpkrohling
Copy link
Member

Changelog conflict resolved.

@bogdandrutu bogdandrutu merged commit 9c3b2c8 into open-telemetry:main Apr 25, 2022
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this pull request May 10, 2022
…pen-telemetry#9422)

* [exporter/datadog] Modify deprecation messages to reflect new plan

* Add CHANGELOG entry

* Capitalize changelog note

Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants