[receiver/kubeletstats] Update scope name to otelcol/kubeletstatsreceiver #9400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
reviewed
Apr 21, 2022
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
dmitryax
approved these changes
Apr 21, 2022
|
Looks like a related test is failing |
Ya that k8sclient test is flaky. Being tracked in #9091. I think the check-collector-module-version test is failing on every branch right now. |
|
this should fix the check-collector-module-version: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/9402/files |
dmitryax
approved these changes
Apr 21, 2022
codeboten
approved these changes
Apr 22, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…iver (open-telemetry#9400) * Update scope name to otelcol/kubeletstatsreceiver * remove unused type parameter * Update changelog Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> Co-authored-by: Alex Boten <aboten@lightstep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update Scope Name to otelcol/kubeletstatsreceiver in all scenarios. Update to v2 metrics builder will happen in a different PR.
Link to tracking Issue:
Fixes #9399
Testing:
Updated unit tests to check for scope name.