Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/k8sattributesprocessor] Add RBAC rules documentation #9365

Merged
merged 4 commits into from
Apr 22, 2022

Conversation

thib92
Copy link
Contributor

@thib92 thib92 commented Apr 19, 2022

Description: Add missing documentation on how to setup RBAC rules for the k8sattributesprocessor

Link to tracking Issue: N/A

Testing: I've tested the documented RBAC rules in my deployment of the collector.

Documentation: This adds an example of RBAC permissions to give to the collector in order to have the k8sattributesprocessor work.

@thib92 thib92 requested a review from a team April 19, 2022 17:49
processor/k8sattributesprocessor/doc.go Outdated Show resolved Hide resolved
processor/k8sattributesprocessor/doc.go Outdated Show resolved Hide resolved
processor/k8sattributesprocessor/doc.go Outdated Show resolved Hide resolved
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
@thib92 thib92 requested a review from dmitryax April 21, 2022 12:53
@pmm-sumo pmm-sumo added ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry labels Apr 22, 2022
@pmm-sumo
Copy link
Contributor

I've seen similar changes to doc.go skipped the changelog in the past so added the label

@thib92
Copy link
Contributor Author

thib92 commented Apr 22, 2022

I wasn't aware of the example folder. Might be worth adding an RBAC example to it? I can do this in a separate PR.

@pmm-sumo
Copy link
Contributor

I wasn't aware of the example folder. Might be worth adding an RBAC example to it? I can do this in a separate PR.

I think that's always a good idea :)

@codeboten codeboten merged commit 92e964e into open-telemetry:main Apr 22, 2022
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this pull request May 10, 2022
…-telemetry#9365)

* Document `k8sattributesprocessor` RBAC rules

* Be more precise on filters

* Be more specific about what the example does

* Apply suggestions from code review

Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants