Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/tailsampling] Cleanly tear down test #9283

Merged
merged 2 commits into from
Apr 18, 2022

Conversation

jpkrohling
Copy link
Member

@jpkrohling jpkrohling commented Apr 14, 2022

This PR changes the factory test to properly initialize and shutdown the processor, so that initialized go routines are properly cleaned. It also adds goleaks to detect leaks of go routines.

Attempts to fix #9126

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling requested review from a team and Aneurysm9 April 14, 2022 18:43
@jpkrohling jpkrohling added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 14, 2022
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test - tailsamplingprocessor - TestConcurrentTraceMapSize
2 participants